From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 3/6] mk: remove library grouping during
	application linking
Date: Fri, 10 Jun 2016 17:14:19 +0200
Message-ID: <2776716.9PsBryk3kK@xps13>
References: <1464367686-3475-1-git-send-email-ferruh.yigit@intel.com>
 <1465564749-1405-4-git-send-email-thomas.monjalon@6wind.com>
 <575AD4A2.9070108@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 062682142
 for <dev@dpdk.org>; Fri, 10 Jun 2016 17:14:22 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id n184so271021044wmn.1
 for <dev@dpdk.org>; Fri, 10 Jun 2016 08:14:22 -0700 (PDT)
In-Reply-To: <575AD4A2.9070108@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-10 15:54, Ferruh Yigit:
> On 6/10/2016 2:19 PM, Thomas Monjalon wrote:
> > From "man ld":
> >   Using this option has a significant performance cost.
> >   It is best to use it only when there are unavoidable
> >   circular references between two or more archives.
> > 
> > Remove the option since it does not seem necessary.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> To remove this, I think we should order libraries in a way:
> 
> pmd -> librte -> external libraries.
> Than we can remove --whole-archive too.
> 
> And perhaps keep it still to wrap around librte_eal and librte_mempool,
> which still has cyclic dependencies.

OK looks good
I let you do a v3