From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] Add toeplitz hash algorithm used by RSS Date: Wed, 03 Jun 2015 16:07:18 +0200 Message-ID: <2783732.C59rBDiv7h@xps13> References: <1430832011-17764-1-git-send-email-medvedkinv@gmail.com> <1431097092-19790-1-git-send-email-medvedkinv@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Vladimir Medvedkin Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 83C043237 for ; Wed, 3 Jun 2015 16:08:10 +0200 (CEST) Received: by wiwd19 with SMTP id d19so54062928wiw.0 for ; Wed, 03 Jun 2015 07:08:10 -0700 (PDT) In-Reply-To: <1431097092-19790-1-git-send-email-medvedkinv@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-05-08 10:58, Vladimir Medvedkin: > Software implementation of the Toeplitz hash function used by RSS. > Can be used either for packet distribution on single queue NIC > or for simulating of RSS computation on specific NIC (for example > after GRE header decapsulating). > > v3 changes > - Rework API to be more generic > - Add sctp_tag into tuple > > v2 changes > - Add ipv6 support > - Various style fixes > > Signed-off-by: Vladimir Medvedkin > --- > lib/librte_hash/Makefile | 1 + > lib/librte_hash/rte_thash.h | 207 ++++++++++++++++++++++++++++++++++++++++++++ Without any comment, it seems this v3 is approved. Maybe that this patch would be even better by implementing some unit tests. I wonder if the hash chapter of the prog guide could list the different algorithms and why/when use them? Thanks