From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 2/2] app/test_pmd: add tests for new API's
Date: Wed, 12 Oct 2016 17:36:41 +0200
Message-ID: <2791430.Y8ncTCNxt5@xps13>
References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com>
 <2251153.ZmgGxBf8Fs@xps13>
 <8CEF83825BEC744B83065625E567D7C21A092012@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Shah, Rahul R" <rahul.r.shah@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>,
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com
 [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 7855737AC
 for <dev@dpdk.org>; Wed, 12 Oct 2016 17:36:43 +0200 (CEST)
Received: by mail-lf0-f52.google.com with SMTP id b81so80397435lfe.1
 for <dev@dpdk.org>; Wed, 12 Oct 2016 08:36:43 -0700 (PDT)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A092012@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-12 15:27, Iremonger, Bernard:
> Hi Thomas,
> 
> <snip>
> 
> > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new
> > API's
> > 
> > 2016-10-12 16:03, Bernard Iremonger:
> > > --- a/app/test-pmd/Makefile
> > > +++ b/app/test-pmd/Makefile
> > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c  SRCS-y += icmpecho.c
> > >  SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c
> > >
> > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
> > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe endif
> > > +
> > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> > > +LDLIBS += -lrte_pmd_ixgbe
> > > +endif
> > > +endif
> > 
> > Sorry if I miss something, but I thought it was enough to do:
> > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe
> 
> No unfortunately not, the above line does not work for all scenarios .
> 
> There are 4 scenarios as follows:
> 
> CONFIG_RTE_LIBRTE_IXGBE_PMD=y  with CONFIG_RTE_BUILD_SHARED_LIB=n
> 
> CONFIG_RTE_LIBRTE_IXGBE_PMD=y  with CONFIG_RTE_BUILD_SHARED_LIB=y
> 
> CONFIG_RTE_LIBRTE_IXGBE_PMD=n  with CONFIG_RTE_BUILD_SHARED_LIB=y
> 
> CONFIG_RTE_LIBRTE_IXGBE_PMD=n  with CONFIG_RTE_BUILD_SHARED_LIB=n
> 
> I have been doing quite a bit of building today to get it to work in all 4 scenarios.

I have a doubt about the tests because LDLIBS-y does not exist.
There is _LDLIBS-y and LDLIBS.
But in the static case, you wrote:
	LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe endif
Please could you check?