From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] i40e: skip any phy config as a workaround
Date: Mon, 23 Nov 2015 23:17:20 +0100
Message-ID: <2795108.MCDRmV9y9P@xps13>
References: <1447744187-32638-1-git-send-email-helin.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Helin Zhang <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 89B828E93
 for <dev@dpdk.org>; Mon, 23 Nov 2015 23:18:37 +0100 (CET)
Received: by wmvv187 with SMTP id v187so182800886wmv.1
 for <dev@dpdk.org>; Mon, 23 Nov 2015 14:18:37 -0800 (PST)
In-Reply-To: <1447744187-32638-1-git-send-email-helin.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-17 15:09, Helin Zhang:
> As firmware does not support any link control from software driver
> side, any phy config should be ignored as a workaround. Otherwise
> the link might not be up again after binding back to kernel driver.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
[...]
> +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw,
> +		   __rte_unused uint8_t abilities,
> +		   __rte_unused uint8_t force_speed)
> +{
> +	/* Skip any phy config on both 10G and 40G interfaces, as a workaround
> +	 * for the link control limitation of that all link control should be
> +	 * handled by firmware. It should follow up if link control will be
> +	 * opened to software driver in future firmware versions.
> +	 */
>  	return I40E_SUCCESS;
>  }

An error code seems more appropriate.
But I guess you perfectly know what you do, so
Applied, thanks