From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 04/13] bus/vdev: add device matching field driver Date: Fri, 21 Sep 2018 14:55:24 +0200 Message-ID: <27955989.SnTzdq47Er@xps> References: <2305853.Xkr2rJqqKv@xps> <20180921115312.sdegsb3ko2mbf7hc@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 877DD1B53 for ; Fri, 21 Sep 2018 14:55:27 +0200 (CEST) In-Reply-To: <20180921115312.sdegsb3ko2mbf7hc@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/09/2018 13:53, Ga=EBtan Rivet: > On Thu, Sep 20, 2018 at 06:11:44PM +0200, Thomas Monjalon wrote: > > 19/09/2018 18:03, Gaetan Rivet: > > > The vdev bus parses a field "driver", matching > > > a vdev driver name with one passed as follows: > > >=20 > > > "bus=3Dvdev,driver=3Dxxxx" > >=20 > > I think the property should be "name". > > We already have a "driver" category. > > So it may be "bus=3Dvdev,name=3Dmytap/driver=3Dtap" > >=20 > > Until now we were using the name of the driver as a prefix for > > the device name because it was the only way of knowing the driver to us= e. > > With a richer syntax like above, this restriction can be removed. >=20 > Do you want all buses to read the driver=3D key and use it to know which > driver to probe, or is it an exception of the vdev bus? Good point. Yes, if the driver=3D key is provided, the bus should respect i= t. It may allow to have 2 different drivers supporting the same PCI ids, and let the user override the default driver to use.