From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal: fix clang compilation error on ARM64 Date: Wed, 11 Apr 2018 22:42:55 +0200 Message-ID: <2796123.plAjDWPncV@xps> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <20180411170150.11985-1-pbhagavatula@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com To: Pavan Nikhilesh Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5C4F71B83A for ; Wed, 11 Apr 2018 22:42:58 +0200 (CEST) In-Reply-To: <20180411170150.11985-1-pbhagavatula@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/04/2018 19:01, Pavan Nikhilesh: > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > The error was: > include/generic/rte_atomic.h:215:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 > include/generic/rte_atomic.h:494:9: error: > implicit declaration of function '__atomic_exchange_4' > is invalid in C99 > include/generic/rte_atomic.h:772:9: error: > implicit declaration of function '__atomic_exchange_8' > is invalid in C99 > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Signed-off-by: Pavan Nikhilesh We did not understand why this error is seen only on ARM (hopefully we won't discover it somewhere else), but it is a pragmatic fix. Applied, thanks