From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4] pmd/snow3g: add new SNOW 3G SW PMD
Date: Thu, 10 Mar 2016 23:56:07 +0100
Message-ID: <2802937.l2eUnEgDO1@xps13>
References: <1457380086-30391-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1457627592-29144-1-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id C88E029CD
 for <dev@dpdk.org>; Thu, 10 Mar 2016 23:57:50 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id p65so6618682wmp.0
 for <dev@dpdk.org>; Thu, 10 Mar 2016 14:57:50 -0800 (PST)
In-Reply-To: <1457627592-29144-1-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-10 16:33, Pablo de Lara:
> +SNOW 3G PMD
> +M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> +F: drivers/crypto/snow3g

Missing doc reference:
F: doc/guides/cryptodevs/snow3g.rst

> +To build DPDK with the SNOW3G_PMD the user is required to get
> +the export controlled libsso library, sending a request to
> +`DPDKUser_software_access@intel.com`, and compile it
> +on their user system before building DPDK:

I'm a bit concerned that this library is not freely available.
It makes testing difficult.

> +The environmental variable LIBSSO_PATH must be exported with the path
> +where you extracted and built the libsso library and finally set
> +CONFIG_RTE_LIBRTE_SNOW3G=y in config/common_base.

It is CONFIG_RTE_LIBRTE_PMD_SNOW3G.

> +# SNOW3G PMD is dependent on the LIBSSO library
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G)     += -lrte_pmd_snow3g
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G)     += -L$(LIBSSO_PATH)/build -lsso
> +
>  endif # ! $(CONFIG_RTE_BUILD_SHARED_LIB)

This is for the static library case.
The PMD should be linked to libsso also in the shared library case.
There is the same problem with -lIPSec_MB (aesni_mb driver).