From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] virtio: fix crash if CQ is not negotiated
Date: Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
Message-ID: <2803320.zIVGhAljtF@xps13>
References: <1432549252-8630-1-git-send-email-damarion@cisco.com>
 <20150526075957.431dae36@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Damjan Marion <damarion@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id E4CA35A0A
 for <dev@dpdk.org>; Fri, 12 Jun 2015 14:50:57 +0200 (CEST)
Received: by wgme6 with SMTP id e6so24172998wgm.2
 for <dev@dpdk.org>; Fri, 12 Jun 2015 05:50:57 -0700 (PDT)
In-Reply-To: <20150526075957.431dae36@urahara>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > Fix NULL dereference if virtio control queue is not negotiated.
> > 
> > Signed-off-by: Damjan Marion <damarion@cisco.com>
> 
> This is good belt and suspenders thing to have, but did you see early
> patches to check the feature bits and not call this code?
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks