From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6] enic: receive path performance improvements Date: Tue, 15 Mar 2016 21:42:54 +0100 Message-ID: <2804669.uFzlJRKE3s@xps13> References: <1456106650-26727-1-git-send-email-johndale@cisco.com> <1457125740-13233-1-git-send-email-johndale@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: John Daley Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 7B1345398 for ; Tue, 15 Mar 2016 21:44:20 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so165540212wml.0 for ; Tue, 15 Mar 2016 13:44:20 -0700 (PDT) In-Reply-To: <1457125740-13233-1-git-send-email-johndale@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-04 13:09, John Daley: > +#ifdef RTE_NEXT_ABI > + pkt_err_flags |= PKT_RX_MAC_ERR; > +#else > + pkt_err_flags |= PKT_EXT_RX_PKT_ERROR; > +#endif > + } > + > + /* Check for bad FCS. MAC error isn't quite, but no other choice */ > + if (!enic_cq_rx_desc_fcs_ok(cqrd)) { > +#ifdef RTE_NEXT_ABI > + pkt_err_flags |= PKT_RX_MAC_ERR; > +#else > + pkt_err_flags |= PKT_EXT_RX_BAD_FCS; > +#endif It seems to be a mistake, leading to build failure when NEXT_ABI is disabled. Will be fixed when rebased on master branch.