From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: add support for gdb debug info generation Date: Tue, 23 Jun 2015 09:47:15 +0200 Message-ID: <28151366.mYixNO6eb8@xps13> References: <1434749378-8578-1-git-send-email-cchemparathy@ezchip.com> <5587BFA7.2000206@netinsight.net> <55890D3A.109@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: "Gonzalez Monroy, Sergio" Return-path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 28F22C790 for ; Tue, 23 Jun 2015 09:48:19 +0200 (CEST) Received: by wgbhy7 with SMTP id hy7so1884091wgb.2 for ; Tue, 23 Jun 2015 00:48:19 -0700 (PDT) In-Reply-To: <55890D3A.109@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-23 08:39, Gonzalez Monroy, Sergio: > On 22/06/2015 08:56, Simon K=E5gstr=F6m wrote: > > On 2015-06-22 09:44, Gonzalez Monroy, Sergio wrote: > >> On 19/06/2015 22:29, Cyril Chemparathy wrote: > >>> From: Cyril Chemparathy > >>> > >>> It is often useful to build with debug enabled, we add a config > >>> (CONFIG_RTE_TOOLCHAIN_DEBUG) to do so. > >>> > >>> +ifeq ($(CONFIG_RTE_TOOLCHAIN_DEBUG),y) > >>> +TOOLCHAIN_CFLAGS +=3D -g -ggdb > >>> +TOOLCHAIN_LDFLAGS +=3D -g -ggdb > >>> +endif > >> I don't think you need to modify the makefiles and introduce a new= > >> compile time option for this. > >> The same result can be easily achieved by setting EXTRA_CFLAGS in = the > >> command line. ie: > >> $ make install T=3Dx86_64-native-linuxapp-gcc EXTRA_CFLAGS=3D= '-g -ggdb' > > Why isn't -g standard though? The binaries should/will anyhow be > > stripped when used for production - but debugging information shoul= d be > > useful when analysing crashes. >=20 > I guess you could argue that, to always build with debug info then st= rip=20 > it down. > You would need another flag to strip debug info for production, or le= ave=20 > it for debugging. >=20 > In my opinion is not worth it, but it you feel strongly about it you = can=20 > submit patches and > let the community decide. I think stripping is a packaging responsibility. It would be a good idea to always provide debugging symbols.