From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 3/3] doc: remove ABI changes in igb_uio
Date: Mon, 30 Jan 2017 18:52:39 +0100
Message-ID: <2816494.kdcLa2jDNL@xps13>
References: <1485243248-27082-1-git-send-email-jianfeng.tan@intel.com>
 <1485243248-27082-4-git-send-email-jianfeng.tan@intel.com>
 <66ee7e72-95a3-1e31-278c-b6823168de6c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, yuanhan.liu@linux.intel.com,
 stephen@networkplumber.org
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 25C743237
 for <dev@dpdk.org>; Mon, 30 Jan 2017 18:52:42 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id b65so42994903wmf.0
 for <dev@dpdk.org>; Mon, 30 Jan 2017 09:52:42 -0800 (PST)
In-Reply-To: <66ee7e72-95a3-1e31-278c-b6823168de6c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-24 13:35, Ferruh Yigit:
> On 1/24/2017 7:34 AM, Jianfeng Tan wrote:
> > We announced ABI changes to remove iomem and ioport mapping in
> > igb_uio. But it has potential backward compatibility issue: cannot
> > run old version DPDK on modified igb_uio.
> > 
> > The purpose of this changes was to fix a bug: when DPDK app crashes,
> > those devices by igb_uio are not stopped either DPDK PMD driver or
> > igb_uio driver. We need to figure out new way to fix this bug.
> 
> Hi Jianfeng,
> 
> I believe it would be good to fix this potential defect.
> 
> Is "remove iomem and ioport" a must for that fix? If so, I suggest
> re-think about it.
> 
> If I see correctly, dpdk1.8 and older uses igb_uio iomem files. So
> backward compatibility is the possible issue for dpdk1.8 and older.
> Since v1.8 two years old, I would prefer fixing defect instead of
> keeping that backward compatibility.
> 
> Jianfeng, Thomas,
> 
> What do you think postponing this deprecation notice to next release,
> instead of removing it, and discuss more?
> 
> 
> And overall, if "remove iomem and ioport" is not a must for this fix, no
> problem to remove deprecation notice.

I have no strong opinion here.
Jianfeng, do you agree with Ferruh?