From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 1/9] ethdev: extend flow director for input selection Date: Wed, 23 Mar 2016 09:45:26 +0100 Message-ID: <2819574.tiGSjDHHFB@xps13> References: <1457580346-18550-1-git-send-email-jingjing.wu@intel.com> <2777481.Ou9arTG791@xps13> <9BB6961774997848B5B42BEC655768F8DDB904@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Zhang, Helin" To: "Wu, Jingjing" Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 754C12904 for ; Wed, 23 Mar 2016 09:47:08 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r129so125685246wmr.1 for ; Wed, 23 Mar 2016 01:47:08 -0700 (PDT) In-Reply-To: <9BB6961774997848B5B42BEC655768F8DDB904@SHSMSX104.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-23 00:42, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-21 14:18, Jingjing Wu: > > > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > > > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > > > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering by > > > tos, protocol and ttl. > > [...] > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -22,10 +22,6 @@ Deprecation Notices > > > * The ethdev structures rte_eth_link, rte_eth_dev_info and rte_eth_conf > > > must be updated to support 100G link and to have a cleaner link speed > > API. > > > > > > -* ABI changes are planned for struct rte_eth_fdir_flow in order to > > > support > > > - extend flow director's input set. The release 2.2 does not contain > > > these ABI > > > - changes, but release 2.3 will, and no backwards compatibility is planned. > > > > The changed structures are part of rte_eth_fdir_flow. > > So this deprecation notice apply to this patch. > > > > > * ABI changes are planned for rte_eth_ipv4_flow and rte_eth_ipv6_flow > > to > > > include more fields to be matched against. The release 2.2 does not > > > contain these ABI changes, but release 2.3 will. > > > > These are the structures changed in this patch. > > I think this section must be also removed. > > This deprecation notice is not raised by me. It is raised by rahul.lakkireddy@chelsio.com at commit 954f1545a1ab. > So, I'm not sure if it is OK for me to remove it in my patch. It does not matter who raised the notice. Your patch match with it. Please remove it.