From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vfio: allow to map other memory regions Date: Mon, 19 Jun 2017 23:04:08 +0200 Message-ID: <2829321.iV2IKkVC0J@xps> References: <1495547976-96270-1-git-send-email-pawelx.wodkowski@intel.com> <1495624659-226807-1-git-send-email-pawelx.wodkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Pawel Wodkowski Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6B81B374 for ; Mon, 19 Jun 2017 23:04:10 +0200 (CEST) In-Reply-To: <1495624659-226807-1-git-send-email-pawelx.wodkowski@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Some comments below 24/05/2017 13:17, Pawel Wodkowski: > Currently it is not possible to use memory that is not owned by DPDK to > perform DMA. This scenarion might be used in vhost applications (like > SPDK) where guest send its own memory table. To fill this gap provide > API to allow registering arbitrary address in VFIO container. > > Signed-off-by: Pawel Wodkowski > --- > lib/librte_eal/linuxapp/eal/Makefile | 3 + > lib/librte_eal/linuxapp/eal/eal_vfio.c | 142 +++++++++++++++++++++--- > lib/librte_eal/linuxapp/eal/eal_vfio.h | 10 ++ > lib/librte_eal/linuxapp/eal/include/rte_iommu.h | 78 +++++++++++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 ++ > 5 files changed, 224 insertions(+), 17 deletions(-) > create mode 100644 lib/librte_eal/linuxapp/eal/include/rte_iommu.h VFIO is not referenced in the doxygen of these functions. Could we use this API for something else than VFIO? Any API should be declared in common directory, even if it is not implemented for FreeBSD (returning -ENOTSUP).