From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal: deprecate rte_cpu_check_supported
Date: Tue, 04 Apr 2017 15:26:47 +0200
Message-ID: <2833575.ok4SoAkeVM@xps13>
References: <20170331183122.22961-1-aconole@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Aaron Conole <aconole@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com
 [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id A88A8326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 15:26:50 +0200 (CEST)
Received: by mail-wr0-f176.google.com with SMTP id w43so214348157wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 06:26:50 -0700 (PDT)
In-Reply-To: <20170331183122.22961-1-aconole@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-03-31 14:31, Aaron Conole:
> It's likely that this function isn't used anywhere, but since it was part of
> the public API, mark the function for deprecation for at least one release.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
[...]
> --- a/lib/librte_eal/common/arch/x86/rte_spinlock.c
> +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c
> @@ -33,6 +33,7 @@
>  
>  #include <stdint.h>
>  
> +#include "rte_common.h"
>  #include "rte_cpuflags.h"

This include should be added in rte_cpuflags.h.
There are other C files which could need rte_common.h,
example: test/test/test_cpuflags.c

[...]
> --- a/lib/librte_eal/common/include/generic/rte_cpuflags.h
> +++ b/lib/librte_eal/common/include/generic/rte_cpuflags.h
> @@ -78,9 +78,10 @@ rte_cpu_get_flag_enabled(enum rte_cpu_flag_t feature);
>   * This function checks that the currently used CPU supports the CPU features
>   * that were specified at compile time. It is called automatically within the
>   * EAL, so does not need to be used by applications.
> + * This version is replaced by rte_cpu_is_supported
>   */
>  void
> -rte_cpu_check_supported(void);
> +rte_cpu_check_supported(void) __rte_deprecated;

The deprecated flag must be moved before the function declaration.
Otherwise clangs throws an error.

[...]
> +DPDK_17.05 {
> +	global;
> +
> +	rte_cpu_is_supported;
> +
> +} DPDK_17.02;

Should not it be a separate patch?