From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/4] net/virtio: skip device probe in vdpa mode Date: Sat, 31 Mar 2018 15:16:20 +0200 Message-ID: <2836028.8kLeaZ6SVA@xps> References: <20180321132108.52464-4-xiao.w.wang@intel.com> <20180331022929.42172-3-xiao.w.wang@intel.com> <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Xiao Wang , ferruh.yigit@intel.com, dev@dpdk.org, zhihong.wang@intel.com, yliu@fridaylinux.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, cunming.liang@intel.com, dan.daly@intel.com, gaetan.rivet@6wind.com, anatoly.burakov@intel.com To: Maxime Coquelin Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 010E24C74 for ; Sat, 31 Mar 2018 15:16:42 +0200 (CEST) In-Reply-To: <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 31/03/2018 13:13, Maxime Coquelin: > On 03/31/2018 04:29 AM, Xiao Wang wrote: > > If we want a virtio device to work in vDPA (vhost data path acceleration) > > mode, we could add a "vdpa=1" devarg for this device to specify the mode. > > > > This patch let virtio pmd skip device probe when detecting this parameter. > > As we discussed, I would prefer a generic solution at EAL level. Please could you explain the requirement and the context? Can we use RTE_ETH_DEV_DEFERRED state and device ownership? Without knowing what's behind, I would say that a PMD should never skip a device by itself, but let other entities decide what to do with the probed device (thanks to probe notifications).