From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: check string parameter lengths Date: Thu, 17 Jan 2019 17:41:57 +0100 Message-ID: <2838296.dFoSHF3S7s@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, yuwei1.zhang@intel.com, bruce.richardson@intel.com, stable@dpdk.org To: Anatoly Burakov Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/01/2019 13:12, Anatoly Burakov: > When specifying parameters such as hugefile prefix from the > command-line, it is possibly to supply an empty string. This may > lead to various problems: for example, if hugefile prefix is > empty, the runtime config path construction may end up > looking like "/var/run/dpdk//_config", which will technically > work, but is wrong and places files in the wrong place. > > To fix it, check lengths of such user-specified parameters for > hugefile prefix, as well as hugepage dir and user-specified > mbuf pool ops string. > > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks