From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] i40evf: fix link info update
Date: Fri, 01 Apr 2016 10:23:35 +0200
Message-ID: <2849253.L9bo604lkH@xps13>
References: <1459474604-2049-1-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, helin.zhang@intel.com
To: Jingjing Wu <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 953662BC9
 for <dev@dpdk.org>; Fri,  1 Apr 2016 10:25:30 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id p65so13229193wmp.0
 for <dev@dpdk.org>; Fri, 01 Apr 2016 01:25:30 -0700 (PDT)
In-Reply-To: <1459474604-2049-1-git-send-email-jingjing.wu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jingjing,

Please rebase on top of Marc's patches.

2016-04-01 09:36, Jingjing Wu:
> +* **i40e: Fixed link info of VF

a blank line is missing

> +  Previously, the VF's link speed kept as 10G and status always was up. It did not
> +  change even the physical link's status changed. Now this issue is fixed to make
> +  VF's link info consistent with physical link.

[...]
> +			new_link.link_speed = ETH_LINK_SPEED_100;
> +			break;
> +		case I40E_LINK_SPEED_1GB:
> +			new_link.link_speed = ETH_LINK_SPEED_1000;

These speeds have new names after Marc's rework.

> +		new_link.link_status = vf->link_up ? 1 : 0;

Please use new constants for link up and down.