From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v8] ethdev: check Rx/Tx offloads
Date: Tue, 8 May 2018 12:02:33 +0100
Message-ID: <284eda96-2db4-6c64-f17f-7c3bd88ac019@intel.com>
References: <1525442529-12723-1-git-send-email-wei.dai@intel.com>
 <1525773917-62792-1-git-send-email-wei.dai@intel.com>
 <60bdea5d-2b90-0986-9f0f-c952bc722ce7@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Andrew Rybchenko <arybchenko@solarflare.com>, Wei Dai
 <wei.dai@intel.com>, thomas@monjalon.net, declan.doherty@intel.com,
 linville@tuxdriver.com, mw@semihalf.com, mk@semihalf.com,
 gtzalik@amazon.com, evgenys@amazon.com, ravi1.kumar@amd.com,
 shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com,
 john.miller@atomicrules.com, ajit.khaparde@broadcom.com,
 somnath.kotur@broadcom.com, jerin.jacob@caviumnetworks.com,
 maciej.czekaj@caviumnetworks.com, shijith.thotton@cavium.com,
 ssrinivasan@cavium.com, santosh.shukla@caviumnetworks.com,
 rahul.lakkireddy@chelsio.com, ohndale@cisco.com, hyonkim@cisco.com,
 wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, beilei.xing@intel.com,
 qi.z.zhang@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com,
 tdu@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 jianbo.liu@arm.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 432077CC6
 for <dev@dpdk.org>; Tue,  8 May 2018 13:02:46 +0200 (CEST)
In-Reply-To: <60bdea5d-2b90-0986-9f0f-c952bc722ce7@solarflare.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/8/2018 11:41 AM, Andrew Rybchenko wrote:
> On 05/08/2018 01:05 PM, Wei Dai wrote:
> 
> [...]
> 
>> In the beginning of [rt]x_queue_setup( ) of underlying PMD,
>> add offloads = [rt]xconf->offloads |
>> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API
>> defined in 17.11 to avoid upper application broken due to offload
>> API change.
>> PMD can use the info that input [rt]xconf->offloads only carry
>> the new added per-queue offloads to do some optimization or some
>> code change on base of this patch.
> 
> It looks like I've missed why PMDs should be updated to
> add device offloads to per-queue offloads.
> Cannot it be done on ethdev layer? PMD still can find out
> which offloads were enabled on device level by
> checking [rt]xmode->offlaods.

The stripping [rt]xconf->offloads part added into ethdev layer. This changed the
input set to the PMDs.

Above coded added to keep the input same for the PMDs. Expectation is later PMD
update its code to use new input and remove this update.

> 
>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> [...]
>