From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix leak in hotplug add on parse error
Date: Thu, 03 Aug 2017 22:06:43 +0200
Message-ID: <2852960.RY6FMqKSor@xps>
References: <90dae107bf7e55ec42ae8223d5666a77bd9ddfe7.1501763614.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 238BE2C16
 for <dev@dpdk.org>; Thu,  3 Aug 2017 22:06:46 +0200 (CEST)
In-Reply-To: <90dae107bf7e55ec42ae8223d5666a77bd9ddfe7.1501763614.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/08/2017 14:34, Gaetan Rivet:
> If rte_eal_devargs_parse fails, the rte_devargs has not yet been inserted
> in the global list. When jumping to err_devarg, the removal fails and it
> is not properly freed.
> 
> Free the allocated rte_devargs if its removal failed.
> 
> Coverity issue: 158658
> Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks