From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost/crypto: fix build issue with GCC 4.7.2 Date: Fri, 27 Apr 2018 11:25:45 +0200 Message-ID: <2855253.2u4rUxKpDl@xps> References: <20180427090438.31506-1-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, jianfeng.tan@intel.com, roy.fan.zhang@intel.com To: Maxime Coquelin Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 78EF58D9F for ; Fri, 27 Apr 2018 11:25:47 +0200 (CEST) In-Reply-To: <20180427090438.31506-1-maxime.coquelin@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/04/2018 11:04, Maxime Coquelin: > Build error has been reported by Intel build system: > SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2 > lib/librte_vhost/vhost_crypto.c: In function =E2=80=98rte_vhost_crypto_se= t_zero_copy=E2=80=99: > lib/librte_vhost/vhost_crypto.c:1192:2: error: comparison of unsigned exp= ression < 0 is always false [-Werror=3Dtype-limits] >=20 > As enums can be either signed or unsigned, this patch removes > the negative check and cast to unsigned the upper limit check. >=20 > Fixes: 939066d96563 ("vhost/crypto: add public function implementation") >=20 > Signed-off-by: Maxime Coquelin Applied, thanks