From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9FFC433ED for ; Tue, 11 May 2021 14:12:57 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id AD4F661155 for ; Tue, 11 May 2021 14:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD4F661155 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9B1640140; Tue, 11 May 2021 16:12:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 6C4CC4003E for ; Tue, 11 May 2021 16:12:54 +0200 (CEST) IronPort-SDR: S3Ud/Lb3KdkZd5zGdJAjK02WID5p638MoMEXnS/0Mk2iJBNMzeOSZ+ieE0xpopQtJQugfFRuWW lJbPb+0S52yw== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="220411173" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="220411173" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 07:12:52 -0700 IronPort-SDR: TSOZ6LseKdao00qqltxOUCyWnzT9TINGeV6WziZTwr5x4HPTpARKoe21lzCjCxAUWkX/RAkCsl Z4jJpJXweSSA== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="537046477" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 07:12:51 -0700 To: Ciara Loftus References: <20210510084754.48771-1-ciara.loftus@intel.com> Cc: dev@dpdk.org From: Ferruh Yigit X-User: ferruhy Message-ID: <28607ab0-f46d-47ca-5633-9aa50ad6ee1c@intel.com> Date: Tue, 11 May 2021 15:12:47 +0100 MIME-Version: 1.0 In-Reply-To: <20210510084754.48771-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix build warning for kernels < 5.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/10/2021 9:47 AM, Ciara Loftus wrote: > Prior to this change, two implementations of rx_syscall_handler > existed although only one was needed (for the zero copy path which > is only available from kernel 5.4 and onwards). Remove the second > definition from compat.h and move the first definition back to where > it is called in the Rx function. Doing this removes a build warning > on kernels before 5.4 which complained about the second function > being defined but not used. > > Fixes: 2aa51cdd559e ("net/af_xdp: fix trigger for syscall on Tx") > > Signed-off-by: Ciara Loftus Applied to dpdk-next-net/main, thanks.