From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] app/testpmd: fix burst stat reporting Date: Mon, 21 May 2018 17:15:22 +0200 Message-ID: <2864743.lYVmoJq7xL@xps> References: <20180504201209.2964-1-dashel@microsoft.com> <20180514211147.19784-1-dashel@microsoft.com> <8CEF83825BEC744B83065625E567D7C24E0CD2C8@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Iremonger, Bernard" , "Lu, Wenzhuo" , "Wu, Jingjing" To: Daniel Shelepov Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0FFD91B1D6 for ; Mon, 21 May 2018 17:15:27 +0200 (CEST) In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CD2C8@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects > > burst statistics and includes them in the port stats report. The summary > > should include top 2 most frequent burst sizes, but there is a bug in finding > > the top-2. During the scan of burst size counts, the > > top-2 can change only if top-1 also changes. > > > > Added logic to update the top-2 if current burst size is larger than existing > > top-2, but smaller than existing top-1. > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Daniel Shelepov > > Acked-by: Bernard Iremonger Applied, thanks