From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] enic: fix warnings Date: Thu, 04 Dec 2014 11:48:29 +0100 Message-ID: <2887963.q9hPn3S3sv@xps13> References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Sujith Sankar (ssujith)" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-12-04 10:29, Sujith Sankar: > > On 02/12/14 8:29 pm, "Thomas Monjalon" wrote: > > >A lot of warnings were not seen because $(WERROR_FLAGS) was not set > >in the Makefile. But they appear with toolchains that enforce more checks. > > > >-Wno-deprecated seems useless. > >-Wno-strict-aliasing is added to avoid false positives. > > > >This patch cleans up unused variable, unused functions, wrong types, > >static declarations, etc. A lot of functions have unused parameters; > >it suggests that more clean-up could be needed. > > > >Signed-off-by: Thomas Monjalon > >--- > > lib/librte_pmd_enic/Makefile | 3 +- > > lib/librte_pmd_enic/enic.h | 4 +- > > lib/librte_pmd_enic/enic_ethdev.c | 20 ++++----- > > Thomas, the name of this file got modified. It was enic_etherdev.c in my > submission. > Any idea how this happened? I do not remember seeing a request for this. Yes, sorry I forgot to request it. I renamed the file to be consistent with other drivers. Everywhere in DPDK we talk about ethdev for device operations, not etherdev. -- Thomas