From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix applications failure on configure Date: Tue, 01 May 2018 17:59:33 +0200 Message-ID: <2898570.6ZVCGMQ03T@xps> References: <20180501133343.125260-1-ferruh.yigit@intel.com> <5512562.2HDlAgTDzM@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, xuemingl@mellanox.com To: Ferruh Yigit Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 22533DED for ; Tue, 1 May 2018 17:59:36 +0200 (CEST) In-Reply-To: <5512562.2HDlAgTDzM@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/05/2018 17:30, Thomas Monjalon: > 01/05/2018 15:33, Ferruh Yigit: > > Many sample applications fail because of > > dev_info.flow_type_rss_offloads check in rte_eth_dev_configure() > > > > The sample applications need to be fixed/updated before returning error > > on rte_eth_dev_configure() > > > > This patch keeps the error log but removes returning error. > > > > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") > > Cc: xuemingl@mellanox.com > > > > Signed-off-by: Ferruh Yigit > > Applied, thanks I've also removed the error return for rte_eth_dev_rss_hash_update which was introduced by the same above patch. Signed-off-by: Thomas Monjalon