From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: Make XEN_PMD build in combined library mode Date: Thu, 03 Dec 2015 00:14:27 +0100 Message-ID: <2898846.N9SNaCC8LE@xps13> References: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 261E95913 for ; Thu, 3 Dec 2015 00:15:38 +0100 (CET) Received: by wmww144 with SMTP id w144so78040505wmw.0 for ; Wed, 02 Dec 2015 15:15:38 -0800 (PST) In-Reply-To: <1449059922-10976-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-02 13:38, Christian Ehrhardt: > Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was > enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). > Now the underlying issue is rather simple, the xen code needs libxenstore. > But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was > disabled. > While it is correct to create the DPDK sublib linking only in the > RTE_BUILD_COMBINE_LIBS=n case, the libxenstore should be added to the linked > libs in any case if RTE_LIBRTE_PMD_XENVIRT is enabled. [...] > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -113,6 +113,7 @@ endif # ! CONFIG_RTE_BUILD_SHARED_LIBS > _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz > > _LDLIBS-y += --start-group > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore Why is it moved after --start-group and not above as other dependencies? > ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)