From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v4 1/2] lib/power: add bit for high frequency
	cores
Date: Mon, 1 Apr 2019 16:49:20 +0100
Message-ID: <28b75883-2dd5-bd9d-69bb-cbc7d263a182@intel.com>
References: <20190329131520.10653-1-david.hunt@intel.com>
 <20190401153044.39273-1-david.hunt@intel.com>
 <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: liang.j.ma@intel.com
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 215CE4CA7
 for <dev@dpdk.org>; Mon,  1 Apr 2019 17:49:22 +0200 (CEST)
In-Reply-To: <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Anatoly,

On 1/4/2019 4:43 PM, Burakov, Anatoly wrote:
> On 01-Apr-19 4:30 PM, David Hunt wrote:
>> This patch adds a new bit in the capabilities mask that's returned by
>> rte_power_get_capabilities(), allowing application to query which cores
>> have the higher frequencies, and can then pin the workloads accordingly.
>>
>> Returned Bits:
>>   0 - Turbo Boost enabled
>>   1 - Higher core base_frequency
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>
> <snip>
>
>>       /* Add MSR read to detect turbo status */
>>         if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) 
>> < 0)
>> @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct 
>> pstate_power_info *pi)
>>         pi->non_turbo_max_ratio = max_non_turbo;
>>   +    /*Add the compare for base frequency  */
>
> The comment here looks meaningless, and needs to be reworded to 
> explain why this is done, not what is done.
>
> Otherwise,
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
>

OK, Thanks for that. I'll push a v5 shortly, including your Reviewed-by tag.

Rgds,
Dave.