From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/2] eal: introduce rte_prefetch_non_temporal
Date: Thu, 11 Feb 2016 12:00:27 +0100
Message-ID: <2906426.LWxznbFVkn@xps13>
References: <1449415470-25545-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1449415470-25545-2-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, viktorin@rehivetech.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id C48A3688E
 for <dev@dpdk.org>; Thu, 11 Feb 2016 12:01:55 +0100 (CET)
Received: by mail-wm0-f54.google.com with SMTP id p63so67342633wmp.1
 for <dev@dpdk.org>; Thu, 11 Feb 2016 03:01:55 -0800 (PST)
In-Reply-To: <1449415470-25545-2-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Please arch maintainers, your ack would be appreciated.

2015-12-06 20:54, Jerin Jacob:
> +static inline void rte_prefetch_non_temporal(const volatile void *p)
> +{
> +	rte_prefetch0(p);
> +}

A comment about using the same instruction for temporal and non-temporal?

> +/**
> + * Prefetch a cache line into all cache levels(non-temporal/transient version)

space missing before paren