From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] eal/x86: get hypervisor name
Date: Wed, 03 Jan 2018 09:11:02 +0100
Message-ID: <2914779.8I0g9CxD1t@xps>
References: <20171130214720.30098-1-thomas@monjalon.net>
 <20171230224723.13147-1-thomas@monjalon.net>
 <20180102083405.2ffd9bed@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D73C31B170
 for <dev@dpdk.org>; Wed,  3 Jan 2018 09:11:21 +0100 (CET)
In-Reply-To: <20180102083405.2ffd9bed@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/01/2018 17:34, Stephen Hemminger:
> On Sat, 30 Dec 2017 23:47:23 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > The CPUID instruction is catched by hypervisor which can return
> > a flag indicating one is running, and its name.
> > 
> > Suggested-by: Stephen Hemminger <sthemmin@microsoft.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > v2 changes:
> > 	- remove C99 style declaration
> > 	- move code in rte_hypervisor.* files
> > 	- add a function to get the name string
> 
> Looks good to me.
> What about Xen?

Xen is not supported in DPDK currently.
So it will be handled as "unknown".
Xen awareness can be added later with some driver support.