From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] eal: fix check when retrieving current cpu
 affinity
Date: Tue, 19 Feb 2019 11:40:19 +0000
Message-ID: <29172348-cc0c-1b36-cefc-6b3ef92137f1@intel.com>
References: <1550150874-9535-1-git-send-email-david.marchand@redhat.com>
 <1fed1442-efc2-0156-7db1-8b2c01292659@intel.com>
 <CAJFAV8ya=_yQsCN5ok+t-+pkuhH=vEj1UY88O9pNev-R+AH3tA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: David Marchand <david.marchand@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 9B5F35699
 for <dev@dpdk.org>; Tue, 19 Feb 2019 12:40:37 +0100 (CET)
In-Reply-To: <CAJFAV8ya=_yQsCN5ok+t-+pkuhH=vEj1UY88O9pNev-R+AH3tA@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 14-Feb-19 5:41 PM, David Marchand wrote:
> 
> 
> On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly 
> <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> 
>     On 14-Feb-19 1:27 PM, David Marchand wrote:
>      > pthread_getaffinity_np returns a >0 value when failing.
>      >
>      > This is mainly for the sake of correctness.
>      > The only case where it could fail is when passing an incorrect cpuset
>      > size wrt to the kernel.
>      >
>      > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
>      > Signed-off-by: David Marchand <david.marchand@redhat.com
>     <mailto:david.marchand@redhat.com>>
>      > ---
>      >   lib/librte_eal/common/eal_common_options.c | 5 ++---
>      >   1 file changed, 2 insertions(+), 3 deletions(-)
>      >
>      > diff --git a/lib/librte_eal/common/eal_common_options.c
>     b/lib/librte_eal/common/eal_common_options.c
>      > index 6c96f45..1f45f82 100644
>      > --- a/lib/librte_eal/common/eal_common_options.c
>      > +++ b/lib/librte_eal/common/eal_common_options.c
>      > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
>      >       unsigned int lcore_id;
>      >       unsigned int removed = 0;
>      >       rte_cpuset_t affinity_set;
>      > -     pthread_t tid = pthread_self();
>      >
>      > -     if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
>      > -                             &affinity_set) < 0)
>      > +     if (pthread_getaffinity_np(pthread_self(),
>     sizeof(rte_cpuset_t),
>      > +                             &affinity_set))
>      >               CPU_ZERO(&affinity_set);
>      >
>      >       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
>      >
>     CC: stable?
> 
> 
> Not really sure about CCing stable for this.
> 
> I did not get errors with pthread_getaffinity_np so far.
> Afaiu, it would need the kernel and libc to have different cpuset sizes.
> I did not investigate in which situations it could happen.
> 

You're incorrectly handling error condition - that's a bug regardless of 
how likely it is to occur :)

-- 
Thanks,
Anatoly