From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5] compress/qat: enable dynamic huffman
	encoding
Date: Thu, 25 Oct 2018 08:45:17 +0200
Message-ID: <2919877.NPW9lr0NG8@xps>
References: <1539645382-17112-1-git-send-email-fiona.trahe@intel.com>
 <3737696.dzgjCPvWHI@xps>
 <348A99DA5F5B7549AA880327E580B43589657639@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>, "Jozwiak,
 TomaszX" <tomaszx.jozwiak@intel.com>, "Kusztal,
 ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2B5502BB0
 for <dev@dpdk.org>; Thu, 25 Oct 2018 08:45:18 +0200 (CEST)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43589657639@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/10/2018 02:40, Trahe, Fiona:
> I'll send a v6.
> On which OS/compiler did this fail to compile?

It fails on i686 of course.

I already sent some general notes in the past, explaining how %lx
is most of the time wrong. %PRIu64 is the right specifier.

https://www.mail-archive.com/dev@dpdk.org/msg90644.html

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 24/10/2018 16:15, Akhil Goyal:
> > >
> > > On 10/18/2018 2:18 AM, Fiona Trahe wrote:
> > > > Enable dynamic huffman encoding in the QAT comp PMD.
> > > >
> > > > Signed-off-by: Tomasz Jozwiak<tomaszx.jozwiak@intel.com>
> > > > Signed-off-by: Fiona Trahe<fiona.trahe@intel.com>
> > > > Acked-by: Arek Kusztal<arkadiuszx.kusztal@intel.com>
> > > > ---
> > > Applied to dpdk-next-crypto
> >=20
> > error: format =E2=80=98%lx=E2=80=99 expects argument of type =E2=80=98l=
ong unsigned int=E2=80=99, but argument 7 has type =E2=80=98phys_addr_t=E2=
=80=99
> > {aka =E2=80=98long long unsigned int=E2=80=99} [-Werror=3Dformat=3D]
> >     "%s(): " fmt "\n", __func__, ## args)
> >     ^~~~~~~~
> > drivers/compress/qat/qat_comp_pmd.c:194:2: note: in expansion of macro =
=E2=80=98QAT_LOG=E2=80=99
> >   QAT_LOG(DEBUG, "Memzone %s: addr =3D %p, phys =3D %lx, size required =
%d,"
> >=20
> >=20
> > One more comment about the release notes, please try to integrate
> > compressdev features between cryptodev and eventdev.
> >=20
>=20
>=20