From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA2AC61DC4 for ; Thu, 27 Aug 2026 15:16:02 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC8440A8B; Thu, 27 Aug 2026 17:15:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id D9539406A2 for ; Thu, 27 Aug 2026 17:15:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787843703; x=1819379703; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=y0vgPg+ezNzYawqe+9kPoipOUFOrce93oCkcCT+iHTU=; b=a7Izlpjnn6a8yMCe9dym36OFG264yvXpzaLk13dqKy5t3uMV9Z8JMsB1 a9YSS3Nf0LHdBgYqSvAi0Q3Qfbk8JcuK9jnD6Hx1WrMKdsaeYxiOy87ge teIoNykB+pjmRPXd0L+Vpu47vft9mQ4LPJh19DALKDPYZGm/5IpDgTRQm pLdYaye8P9XncPZEX6QLXU8U6mZT1musUz9VlDhAYHFOmQYgyxE5Sc5mS UCmq6jqDziOM4HGwZG0awSPCdZbQ+9FC/hZW4X0E07ClKG0FGGwBVNdCo SUds5RfJam0RM3ZlafiKCPAArZcfm8VHFydfDggFuxuTRcKVCQxv7TwXW g==; X-CSE-ConnectionGUID: 1hCxbuGNSLSbgbBYusSiyA== X-CSE-MsgGUID: w0eHkxleQY+l6gIBRS6jhw== X-IronPort-AV: E=McAfee;i="6800,10657,11888"; a="88371629" X-IronPort-AV: E=Sophos;i="6.25,246,1779174000"; d="scan'208";a="88371629" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2026 08:15:02 -0700 X-CSE-ConnectionGUID: 4b5QrH8mTFSX64xmhIXMZw== X-CSE-MsgGUID: FB8GVexbQmqo6/oImGDkVQ== X-ExtLoop1: 1 Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by fmviesa003.fm.intel.com with ESMTP; 27 Aug 2026 08:15:01 -0700 From: Anatoly Burakov To: dev@dpdk.org, Bruce Richardson Subject: [PATCH v13 09/24] vfio: add container device assignment API Date: Thu, 27 Aug 2026 16:14:12 +0100 Message-ID: <291f878ffaaa7b53d66f6470139308d8a7668cff.1787843386.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, VFIO has explicit group bind API's, but the way they're used is such that no one actually cares about VFIO groups, and the real goal of everyone using VFIO group bind API is to bind devices to particular VFIO container, such that when `dev_vfio_setup_device` call eventually comes, VFIO will pick up the correct container. To remove dependency on group API's, add a new "container assign device" API call that will do the same thing, but will not depend on managing VFIO group fd's. Signed-off-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 10 ++++++++++ lib/eal/include/dev_vfio.h | 26 ++++++++++++++++++++++++++ lib/eal/linux/eal_vfio.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 2990cf14cd..0650abf406 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -950,3 +950,13 @@ dev_vfio_container_dma_unmap(__rte_unused int container_fd, rte_errno = ENOTSUP; return -1; } + +RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_assign_device) +int +dev_vfio_container_assign_device(__rte_unused int vfio_container_fd, + __rte_unused const char *sysfs_base, + __rte_unused const char *dev_addr) +{ + rte_errno = ENOTSUP; + return -1; +} diff --git a/lib/eal/include/dev_vfio.h b/lib/eal/include/dev_vfio.h index 3719cc6adc..85b4dbd3fc 100644 --- a/lib/eal/include/dev_vfio.h +++ b/lib/eal/include/dev_vfio.h @@ -280,6 +280,32 @@ __rte_internal int dev_vfio_container_destroy(int container_fd); +/** + * @internal + * + * Assign a device to a VFIO container. + * + * Doing so will cause `dev_vfio_setup_device()` call to set up the device with + * the VFIO container specified in this assign operation. + * + * This function is only relevant on Linux. + * + * @param vfio_container_fd + * VFIO container file descriptor. + * @param sysfs_base + * Sysfs path prefix. + * @param dev_addr + * Device identifier. + * + * @return + * 0 on success. + * <0 on failure. + */ +__rte_internal +int +dev_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr); + /** * @internal * Bind a IOMMU group to a container. diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c index a64173fe7f..29c03d01b4 100644 --- a/lib/eal/linux/eal_vfio.c +++ b/lib/eal/linux/eal_vfio.c @@ -2109,6 +2109,38 @@ dev_vfio_container_destroy(int container_fd) return 0; } +RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_assign_device) +int +dev_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr) +{ + int iommu_group_num; + int ret; + + ret = dev_vfio_get_group_num(sysfs_base, dev_addr, &iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, "Cannot get IOMMU group number for device %s", + dev_addr); + return -1; + } else if (ret == 0) { + EAL_LOG(ERR, + "Device %s is not assigned to any IOMMU group", + dev_addr); + return -1; + } + + ret = dev_vfio_container_group_bind(vfio_container_fd, + iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, + "Cannot bind IOMMU group %d for device %s", + iommu_group_num, dev_addr); + return -1; + } + + return 0; +} + RTE_EXPORT_INTERNAL_SYMBOL(dev_vfio_container_group_bind) int dev_vfio_container_group_bind(int container_fd, int iommu_group_num) -- 2.52.0