From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 0/3] examples/l3fwd: merge l3fwd-acl code into l3fwd Date: Wed, 23 Jan 2019 18:26:36 +0100 Message-ID: <2922307.MMPdoxV78S@xps> References: <1489008729-28784-2-git-send-email-rkerur@gmail.com> <2510395.XNuST6rEQr@xps> <2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Yigit, Ferruh" , Ravi Kerur , dpdk-dev , "Mcnamara, John" To: "Ananyev, Konstantin" Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B9FD02B87 for ; Wed, 23 Jan 2019 18:26:39 +0100 (CET) In-Reply-To: <2601191342CEEE43887BDE71AB977258010D907202@irsmsx105.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/01/2019 18:20, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 23/01/2019 17:32, Ferruh Yigit: > > > On 3/10/2017 8:58 PM, rkerur at gmail.com (Ravi Kerur) wrote: > > > > This patchset merges l3fwd-acl and l3fwd code into common directory. > > > > Adds config file read option to build LPM and EM tables. > > > > > > > > Ravi Kerur (3): > > > > examples/l3fwd: merge l3fwd-acl code into l3fwd > > > > examples/l3fwd: add config file support for lpm > > > > examples/l3fwd: add config file support for exact > > > > > > Hi Ravi, > > > > > > These l3fwd patches are in patchwork for a long time, I am updating the patchset > > > as rejected, if it is still relevant please send a new version on top of latest > > > repo. > > > > > > Sorry for any inconvenience caused. > > > > > > For reference patches: > > > https://patches.dpdk.org/patch/21696/ > > > https://patches.dpdk.org/patch/21695/ > > > https://patches.dpdk.org/patch/21697/ > > > > > > doc one: > > > https://patches.dpdk.org/patch/24211/ > > > > This work was going in the right direction. > > > > Totally agree. > > > Konstantin, as the maintainer of the ACL library, > > do you think it is worth to keep this example as standalone or merged? > > My vote is definitely for merging. > That would give us single l3fwd app with 3 different routing methods > (lpm, hash, acl) selectable at run-time, plus routing tables in config file. OK, so we just need to find a volunteer. Ravi started the work a long time ago and did not receive enough review. I'm afraid he's not available anymore.