From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v10 0/5] add unit tests for bitrate,
	latency and pdump libraries
Date: Wed, 01 Aug 2018 09:52:17 +0200
Message-ID: <29483712.ychiUti4Sd@xps>
References: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com,
 Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E1AC81B398
 for <dev@dpdk.org>; Wed,  1 Aug 2018 12:14:13 +0200 (CEST)
In-Reply-To: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/08/2018 00:18, Reshma Pattan:
> v10: fixed clang compiler issues and freed latency stats memzone in laten=
cy
> stats unit tests.
> v9: rebased ontop of latest autotest changes and added new tests to the a=
utotest list
> v8: renamed commit headline and freed the metrics memzone for bitrate ut
> v7: removed unused macros and corrected the comment
> v6: updated ring variable appropriately
> v5: rebased, freed pools and rings, created common patch set
> ---

Sorry, the integration of this patchset is very painful.

After asking for rebase, for clang fix, there are still some basic errors
with 32-bit compilation:

	test_latencystats.c:131:21: error:
	format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long int=E2=
=80=99,
	but argument 2 has type =E2=80=98uint64_t=E2=80=99 {aka =E2=80=98long long=
 unsigned int=E2=80=99}

linkage:

	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined reference to `te=
st_pdump'

or even MAINTAINERS file:

	test/test/sample_packet_forward.c
	test/test/sample_packet_forward.h
	test/test/test_bitratestats.c
	test/test/test_latencystats.c

I have already spent too much time on it, despite it is not fixing 18.08.

Please do a complete detailed review of this series,
so it can be considered for 18.11.