From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 1/3] eal: add new keepalive states &
	callback hooks
Date: Wed, 08 Jun 2016 11:53:09 +0200
Message-ID: <2951960.uL8vF99JUJ@xps13>
References: <1463563818-2249-1-git-send-email-remy.horton@intel.com>
 <1463563818-2249-2-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 9BBBDAA3D
 for <dev@dpdk.org>; Wed,  8 Jun 2016 11:53:10 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id n184so173375426wmn.1
 for <dev@dpdk.org>; Wed, 08 Jun 2016 02:53:10 -0700 (PDT)
In-Reply-To: <1463563818-2249-2-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-18 10:30, Remy Horton:

The explanations are missing.
Probably you should split this patch.

> Signed-off-by: Remy Horton <remy.horton@intel.com>
[...]
> +enum rte_keepalive_state {
> +	UNUSED = 0,
> +	ALIVE = 1,
> +	MISSING = 4,
> +	DEAD = 2,
> +	GONE = 3,
> +	DOZING = 5,
> +	SLEEP = 6
> +};

Please use RTE_ prefix.

[...]
>  /**
> + * Keepalive relay callback.
> + *
> + *  Receives a data pointer passed to rte_keepalive_register_relay_callback()
> + *  and the id of the core for which state is to be forwarded.
> + */

Please document each parameter.

> +typedef void (*rte_keepalive_relay_callback_t)(
> +	void *data,
> +	const int id_core,
> +	enum rte_keepalive_state core_state,
> +	uint64_t last_seen
> +	);

[...]
> +/**
> + * Per-core sleep-time indication.
> + * @param *keepcfg
> + *   Keepalive structure pointer
> + *
> + * This function needs to be called from within the main process loop of
> + * the LCore going to sleep.

Why? Please add more comments.

> + */