From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] malloc: don't skip pad on free
Date: Fri, 20 Jul 2018 11:27:43 +0200
Message-ID: <2958510.WtYFjzW1qE@xps>
References: <038143a314345e9c5bf76b1287497a5c4c9f63ed.1531992860.git.anatoly.burakov@intel.com>
 <cec7b521-58cf-3784-ca6f-5d8cd901cf98@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
 stephen@networkplumber.org, stable@dpdk.org
To: Anatoly Burakov <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <cec7b521-58cf-3784-ca6f-5d8cd901cf98@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/07/2018 18:37, Andrew Rybchenko:
> On 19.07.2018 12:42, Anatoly Burakov wrote:
> > Previously, we were skipping erasing pad because we were
> > expecting it to be freed when we were merging adjacent
> > segments. However, if there were no adjacent segments to
> > merge, we would've skipped erasing the pad, leaving non-zero
> > memory in our free space.
> >
> > Fix this by including pad in the erasing unconditionally.
> >
> > Fixes: e43a9f52b7ff ("malloc: fix pad erasing")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Many thanks, the patch fixes the problem I've observed.
> 
> Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks