From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/5] net/ixgbe: move set VF functions. Date: Fri, 09 Dec 2016 14:04:32 +0100 Message-ID: <29626520.OD9qkZZgkn@xps13> References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> <8CEF83825BEC744B83065625E567D7C224D0601D@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Yigit, Ferruh" , dev@dpdk.org To: "Iremonger, Bernard" Return-path: Received: from mail-wj0-f179.google.com (mail-wj0-f179.google.com [209.85.210.179]) by dpdk.org (Postfix) with ESMTP id 2F4072E83 for ; Fri, 9 Dec 2016 14:04:35 +0100 (CET) Received: by mail-wj0-f179.google.com with SMTP id tk12so14120022wjb.3 for ; Fri, 09 Dec 2016 05:04:35 -0800 (PST) In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D0601D@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-09 12:00, Iremonger, Bernard: > From: Yigit, Ferruh > > Why this patchset doesn't remove ethdev updates for these functions? > > > > ixgbe is the only user for these eth-dev_ops, since code moved to ixgbe > > driver, they and relevant rte_eth_xx functions (and deprecation notice) can > > be removed in this patchset. Most probably after testpmd updated to > > prevent compilation errors. > > My understanding is that the functions should be copied and reworked before being removed from the ethdev, and that the removal should be done in a separate patch set. > > Hi Thomas, > > Could you clarify please. It was announced that these functions will be removed, so they can be safely removed in 17.02, right? In this case, it is a code move: copy, rework and delete in the same patch. And yes, the deprecation notice must be removed at the same time.