From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7 01/13] eal: add option register
	infrastructure
Date: Wed, 24 Oct 2018 16:33:33 +0200
Message-ID: <29630789.dO8WeQshWb@xps>
References: <20181022110014.82153-1-kevin.laatz@intel.com>
 <20181024132725.5142-2-kevin.laatz@intel.com>
 <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org,
 harry.van.haaren@intel.com, stephen@networkplumber.org, shreyansh.jain@nxp.com,
 mattias.ronnblom@ericsson.com, bruce.richardson@intel.com
To: Kevin Laatz <kevin.laatz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 677647CB0
 for <dev@dpdk.org>; Wed, 24 Oct 2018 16:33:32 +0200 (CEST)
In-Reply-To: <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

24/10/2018 16:01, Ga=EBtan Rivet:
> Hi Kevin,
>=20
> On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote:
> > This commit adds infrastructure to EAL that allows an application to
> > register it's init function with EAL. This allows libraries to be
> > initialized at the end of EAL init.
> >=20
> > This infrastructure allows libraries that depend on EAL to be initializ=
ed
> > as part of EAL init, removing circular dependency issues.
> >=20
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>=20
> I think this is good enough,
>=20
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Yes it looks good enough.
And it compiles fine in my test.

> The only remaining issue is rte_option_init().
> Sorry I missed your previous message and did not respond in time, I
> would have opted for leaving a return value to at least be able to stop
> the init on error. It is possible to force the callback type to return
> an error value along with a string / hint describing the error. It
> should not be hard to add it later, so not blocking IMO.

I think you need to set this API as experimental.