From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 1/7] ethdev: add additional ieee1588
	support functions
Date: Tue, 10 Nov 2015 15:16:36 +0100
Message-ID: <2966972.cxZfc4bbJ0@xps13>
References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <3893351.MZRdjpoyuB@xps13>
 <B27915DBBA3421428155699D51E4CFE2023B6D6D@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 780F258C3
 for <dev@dpdk.org>; Tue, 10 Nov 2015 15:17:48 +0100 (CET)
Received: by wmvv187 with SMTP id v187so10135639wmv.1
 for <dev@dpdk.org>; Tue, 10 Nov 2015 06:17:48 -0800 (PST)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023B6D6D@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-10 14:12, Mcnamara, John:
> My preference would be for verb_noun but I think noun_verb was used for consistency with the rest of the Ethdev API (although that isn't quite consistent either). And yes, read() would be more consistent with the timesync API while get() is more consistent with the rest of the Ethdev API. I think it would be best, in this case, to try maintain self-consistency and use rte_eth_timesync_read_time().

Yes, self consistency seems a good option.