From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mem: fix DMA mask width sanity check Date: Wed, 07 Nov 2018 14:43:27 +0100 Message-ID: <2972511.zAN3OYqJLo@xps> References: <20181107094456.23123-1-alejandro.lucero@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , "Burakov, Anatoly" To: Alejandro Lucero Return-path: Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id DCE041BE0 for ; Wed, 7 Nov 2018 14:43:59 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/11/2018 12:47, Ferruh Yigit: > On 11/7/2018 10:14 AM, Burakov, Anatoly wrote: > > On 07-Nov-18 9:44 AM, Alejandro Lucero wrote: > >> Current code has different max DMA mask width values for 32 and 64 > >> bits systems. IOMMU hardware could report a higher supported width > >> than current MAX_DMA_MASK_BITS when RTE_ARCH_64 is not defined. This > >> is actually true with a 32 bits kernel running in a 64 bits server > >> with IOMMU hardware. This could also be a problem with embedded systems > >> using an IOMMU designed for 64 bits in a 32 bits system. > >> > >> This patch leaves a single max DMA mask width which will make sure the > >> mask width is within the range for 64 bits variables used for DMA mask. > >> This also will avoid wrong values because any value higher than > >> 64 bits is likely wrong. > >> > >> Signed-off-by: Alejandro Lucero > >> --- > > > > Acked-by: Anatoly Burakov > > Tested-by: Ferruh Yigit Fixes: 223b7f1d5ef6 ("mem: add function for checking memseg IOVA") Applied, thanks