From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal/linuxapp: fix resource leak Date: Fri, 13 May 2016 12:28:07 +0200 Message-ID: <2977689.TnkrfoPGVf@xps13> References: <1462982465-129762-1-git-send-email-danielx.t.mrzyglod@intel.com> <72463300-a846-43a7-11d4-65a48b6370d0@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, david.marchand@6wind.com To: Sergio Gonzalez Monroy , Daniel Mrzyglod Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 53C979601 for ; Fri, 13 May 2016 12:28:09 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id n129so16766529wmn.1 for ; Fri, 13 May 2016 03:28:09 -0700 (PDT) In-Reply-To: <72463300-a846-43a7-11d4-65a48b6370d0@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-12 08:55, Sergio Gonzalez Monroy: > On 11/05/2016 17:01, Daniel Mrzyglod wrote: > > Fix issue reported by Coverity. > > Coverity ID 97920 > > > > munmap structure of hugepage > > > > leaked_storage: Variable hugepage going out of scope leaks the storage > > it points to. > > > > The system resource will not be reclaimed and reused, reducing the future > > availability of the resource. > > I'm not really fond of this commit messages, but if no one minds them, > so be it. Me too. It looks like a Machine2Machine message. I'd prefer an explanation of what is wrong first, then an explanation of the fix, and at the end, the Coverity ID (can be a tag like Fixes-Coverity-ID: 97920). > > In rte_eal_hugepage_init: Leak of memory or pointers to system resources > > > > Fixes: b6a468ad41d5 ("memory: add --socket-mem option") > > > > Signed-off-by: Daniel Mrzyglod