From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/5] clean up snprintf use for string copying Date: Thu, 04 Apr 2019 22:11:31 +0200 Message-ID: <2985695.VAqBOLQO3E@xps> References: <20190403144505.46234-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 076871B3C0 for ; Thu, 4 Apr 2019 22:11:34 +0200 (CEST) In-Reply-To: <20190403144505.46234-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/04/2019 16:45, Bruce Richardson: > There are quite a few instances remaining in DPDK where snprintf is being > used for string copying. These were not being picked up by our existing > coccinelle script, but that can be fixed by editing the script and running > it against our code. In the process a bug was found and fixed in the > bonding pmd, where we were incorrectly specifiying the buffer length > parameter to snprintf. > > The actual replacement was done in two phases - first replacing all > instances where only the snprintf line in question needed changing, then > fixing the other instances where we also needed to add in the header > include. [Using two stages allowed the header addition to be automated too, > since we had a list of files where every one needed the header inclusion] > > > Bruce Richardson (5): > net/bonding: fix buffer length when printing strings > devtools/cocci: make strlcpy replacement smarter > devtools/cocci: create safer version of strlcpy script > replace snprintf with strlcpy without adding extra include > replace snprintf with strlcpy Applied (with 2 rebase changes), thanks