From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/4] ether: rename version file to match
 library name
Date: Thu, 31 Aug 2017 15:18:47 +0100
Message-ID: <298d123d-2d55-c702-cc14-6dab9eff9ebd@intel.com>
References: <20170831134244.35215-1-bruce.richardson@intel.com>
 <20170831134244.35215-4-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>,
 konstantin.ananyev@intel.com, thomas@monjalon.net, john.griffin@intel.com,
 fiona.trahe@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0E4EE160
 for <dev@dpdk.org>; Thu, 31 Aug 2017 16:20:52 +0200 (CEST)
In-Reply-To: <20170831134244.35215-4-bruce.richardson@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/31/2017 2:42 PM, Bruce Richardson wrote:
> While almost all libraries have the library name match the directory name,
> some libraries and drivers do not. For those that don't, some have the
> version filename use the libname, e.g. null_crypto, others have it use the
> directory name, e.g. ether. Using the library name seems the better
> standard to follow, so rename rte_ether_version.map to
> rte_ethdev_version.map.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_ether/Makefile                                          | 2 +-
>  lib/librte_ether/{rte_ether_version.map => rte_ethdev_version.map} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename lib/librte_ether/{rte_ether_version.map => rte_ethdev_version.map} (100%)
> 
> diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile
> index db692ae4d..27d9766a8 100644
> --- a/lib/librte_ether/Makefile
> +++ b/lib/librte_ether/Makefile
> @@ -39,7 +39,7 @@ LIB = librte_ethdev.a
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
>  
> -EXPORT_MAP := rte_ether_version.map
> +EXPORT_MAP := rte_ethdev_version.map

Why library name and folder name is different for ethdev, will it break
anything if folder also renamed to librte_ethdev? for consistency.

>  
>  LIBABIVER := 6
>  
> diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ethdev_version.map
> similarity index 100%
> rename from lib/librte_ether/rte_ether_version.map
> rename to lib/librte_ether/rte_ethdev_version.map
>