From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: missing __rte_deprecated on rte_eth_stats.imcasts ?
Date: Mon, 23 Nov 2015 01:20:48 +0100
Message-ID: <2992545.C0cUSYYlcR@xps13>
References: <20151122235342.GA28210@mhcomputing.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Matthew Hall <mhall@mhcomputing.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id BDF598D38
 for <dev@dpdk.org>; Mon, 23 Nov 2015 01:22:05 +0100 (CET)
Received: by wmww144 with SMTP id w144so84898115wmw.0
 for <dev@dpdk.org>; Sun, 22 Nov 2015 16:22:04 -0800 (PST)
In-Reply-To: <20151122235342.GA28210@mhcomputing.net>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-11-22 18:53, Matthew Hall:
> I was reading through the deprecations in rte_eth_stats to see if I could fix 
> the pktgen. Of course many fields were marked with __rte_deprecated .
> 
> However I found this one field which said deprecated in its comment, but it 
> lacked __rte_deprecated .

When setting the __rte_deprecated attribute, Stephen wanted to keep imcasts:
http://dpdk.org/dev/patchwork/patch/8732/

> Is the comment wrong, or is the field definition wrong, or did I miss 
> something?

We have to decide if we really want to deprecate it.
I think we should set the deprecated attribute and it seems agreed.

> uint64_t imcasts;
> /**< Deprecated; Total number of multicast received packets. */