From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] app/testpmd: log mbuf pool creation
Date: Tue, 31 May 2016 10:39:33 +0200
Message-ID: <2996941.2Z82H6L4i5@xps13>
References: <1464609857-30162-1-git-send-email-olivier.matz@6wind.com>
 <2644423.ubxL6r272Z@xps13> <574D3FA2.10301@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 38EE42951
 for <dev@dpdk.org>; Tue, 31 May 2016 10:39:38 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id z87so97604935wmh.0
 for <dev@dpdk.org>; Tue, 31 May 2016 01:39:38 -0700 (PDT)
In-Reply-To: <574D3FA2.10301@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-31 09:39, Olivier MATZ:
> Hi Thomas,
> 
> On 05/30/2016 09:44 PM, Thomas Monjalon wrote:
> > 2016-05-30 14:04, Olivier Matz:
> >> Enhance the logs related to mbuf pool creation. Display an info level
> >> log when creating the mbuf, and display the error as a string on failure.
> >>
> >> After the patch, we have:
> >>
> >>   [...]
> >>   EAL:   probe driver: 8086:10fb rte_ixgbe_pmd
> >>   USER1: create a new mbuf pool <mbuf_pool_socket_0>: n=331456, \
> >>       size=2176, socket=0
> >>   EAL: Error - exiting with code: 1
> >>     Cause: Creation of mbuf pool for socket 0 failed: Cannot allocate \
> >>       memory
> > 
> > Yes printing the error reason is a good improvement.
> > But why the previous line is at INFO level? It looks to be a debug.
> >
> 
> Using INFO instead of DEBUG was done on purpose. I think the mbuf
> pool parameters is a valuable information for the user running testpmd,
> especially to ensure it's compatible with best performance.

OK, seems reasonnable.