From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH v2] usertools: script to output version string Date: Mon, 7 Aug 2017 13:17:17 +0000 Message-ID: <2BCD1863-1C9C-422D-83C1-2FFA8673B45A@intel.com> References: <20170706145649.65075-1-keith.wiles@intel.com> <2588998.vour8g1xmE@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 96D2A2B9D for ; Mon, 7 Aug 2017 15:17:19 +0200 (CEST) In-Reply-To: <2588998.vour8g1xmE@xps> Content-Language: en-US Content-ID: <39C37A1C965CFC40994FB82151D80566@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Aug 7, 2017, at 6:35 AM, Thomas Monjalon wrote: >=20 > Hi, >=20 > 06/07/2017 16:56, Keith Wiles: >> +# Locate the rte_version.h file and parse out the version strings. >=20 > I think this script is not needed because we have already > something in mk/rte.sdkconfig.mk. > Example: > % make showversion > 17.08.0-rc4 Executing make to find out a version seems to bit of over kill to me and a = simple script would be much easier IMO. I do not really see harm in having = this script that can output the version into different formats is helpful w= hen running external scripts. Also in the future we are most like going to = replace the build system and then we would need to add this support to that= build system and having it in a standalone script is easier manage in the = long run. >=20 > Do you need more? Regards, Keith