From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [RFC PATCH] mk: symlink every headers first
Date: Wed, 21 Jun 2017 14:27:49 +0000
Message-ID: <2D791B20-6CAC-482D-811B-4B4829242710@intel.com>
References: <20170620212139.9508-1-thomas@monjalon.net>
 <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, "gaetan.rivet@6wind.com"
 <gaetan.rivet@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 858DE292D
 for <dev@dpdk.org>; Wed, 21 Jun 2017 16:27:51 +0200 (CEST)
In-Reply-To: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com>
Content-Language: en-US
Content-ID: <49586D35C7670B449C10180D9ABEDBCF@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Jun 21, 2017, at 5:27 AM, Bruce Richardson <bruce.richardson@intel.com=
> wrote:
>=20
> On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote:
>> If a library or a build tool uses a definition from a driver,
>> there is a build ordering issue, like seen when moving PCI code
>> into a bus driver.
>>=20
>> One option is to keep PCI helpers and some common definitions in EAL.
>> The other option is to symlink every headers at the beginning of
>> the build so they can be included by any other component.
>>=20
>> This patch shows how to achieve the second option.
>>=20
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>=20
> My 2c.
>=20
> This may be worth doing, however, two points to consider.
>=20
> 1. If we look to change build system this may not be worth doing unless
> a compelling need becomes obvious in the short term. In the meantime,
> for cases where it is needed...
> 2. libraries can already access the includes from drivers or other
> places fairly easily, just by adding the relevant "-I" flag to the
> CFLAGS for that lib.
>=20
> That said, since the work is already done developing this, and if it
> doesn't hurt in terms of build time, I suppose we might as well merge
> it in.
>=20
> So tentative ack from me, subject to testing and feedback from others.

+1, I already have to make sure everything is symlinked first in my private=
 DPDK work for other reasons. This patch would allow me to remove that spec=
ial code.

>=20
> /Bruce

Regards,
Keith