From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wiles, Keith" Subject: Re: [PATCH] mbuf: pktmbuf pool create helper for specific mempool ops Date: Fri, 22 Dec 2017 13:53:13 +0000 Message-ID: <2EF32BD2-5F89-48BA-B9DB-10C09BD33297@intel.com> References: <1513942211-8314-1-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "olivier.matz@6wind.com" , "jerin.jacob@caviumnetworks.com" To: Hemant Agrawal Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3E2A71B379 for ; Fri, 22 Dec 2017 14:53:15 +0100 (CET) In-Reply-To: <1513942211-8314-1-git-send-email-hemant.agrawal@nxp.com> Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Dec 22, 2017, at 5:30 AM, Hemant Agrawal wrot= e: >=20 > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. >=20 > Signed-off-by: Hemant Agrawal > --- > This change was discussed in the=20 > "doc: announce ABI change for pktmbuf pool create API" > http://dpdk.org/dev/patchwork/patch/32306/ >=20 > lib/librte_mbuf/rte_mbuf.c | 24 ++++++++++++++++++------ > lib/librte_mbuf/rte_mbuf.h | 42 +++++++++++++++++++++++++++++++++++++++++= + > 2 files changed, 60 insertions(+), 6 deletions(-) >=20 This patch looks good to me, but you forgot the MAP file patch to add the n= ew API. Regards, Keith