From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v2 4/4] net/mlx4: add new Memory
	Region	support
Date: Thu, 10 May 2018 06:01:49 +0000
Message-ID: <2F032BAA-5743-4DA6-96B6-BBDFDCE0CF69@mellanox.com>
References: <20180502231654.7596-1-yskoh@mellanox.com>
 <20180509110906.19462-1-yskoh@mellanox.com>
 <20180509110906.19462-5-yskoh@mellanox.com>
 <274843e9-ed82-9576-baf8-a704babf64c5@intel.com>
 <2DDD3185-6284-4BA3-A187-AED4C96407EB@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0069.outbound.protection.outlook.com [104.47.0.69])
 by dpdk.org (Postfix) with ESMTP id 272171B8F0
 for <dev@dpdk.org>; Thu, 10 May 2018 08:01:52 +0200 (CEST)
In-Reply-To: <2DDD3185-6284-4BA3-A187-AED4C96407EB@mellanox.com>
Content-Language: en-US
Content-ID: <4587578C8A793F42AC5D87998B11066A@eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On May 9, 2018, at 8:00 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>=20
>=20
>> On May 9, 2018, at 4:12 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>=20
>> On 5/9/2018 12:09 PM, Yongseok Koh wrote:
>> <...>
>>=20
>>> +/**
>>> + * Insert an entry to B-tree lookup table.
>>> + *
>>> + * @param bt
>>> + *   Pointer to B-tree structure.
>>> + * @param entry
>>> + *   Pointer to new entry to insert.
>>> + *
>>> + * @return
>>> + *   0 on success, -1 on failure.
>>> + */
>>> +static int
>>> +mr_btree_insert(struct mlx4_mr_btree *bt, struct mlx4_mr_cache *entry)
>>> +{
>>> +	struct mlx4_mr_cache *lkp_tbl;
>>> +	uint16_t idx =3D 0;
>>> +	size_t shift;
>>> +
>>> +	assert(bt !=3D NULL);
>>> +	assert(bt->len <=3D bt->size);
>>> +	assert(bt->len > 0);
>>> +	lkp_tbl =3D *bt->table;
>>> +	/* Find out the slot for insertion. */
>>> +	if (mr_btree_lookup(bt, &idx, entry->start) !=3D UINT32_MAX) {
>>> +		DEBUG("abort insertion to B-tree(%p):"
>>> +		      " already exist at idx=3D%u [0x%lx, 0x%lx) lkey=3D0x%x",
>>> +		      (void *)bt, idx, entry->start, entry->end, entry->lkey);
>>=20
>> This and various other logs causing 32bits build error because of %lx us=
age. Can
>> you please check them?
>>=20
>> I am feeling sad to complain a patch like this just because of log forma=
t issue,
>> we should find a solution to this issue as community, either checkpatch =
checks
>> or automated 32bit builds, I don't know.
>=20
> Bummer. I have to change my bad habit of using %lx. And we will add 32-bi=
t build
> check to our internal system to filter this kind of mistakes beforehand.
>=20
> Will work with Shahaf to fix it and rebase next-net-mlx.

Ferruh, I've sent out a patch to Shahaf to change printing format specifier=
s and
Shahaf will squash it into the previous patches.

However, it seems we had stopped supporting 32-bit compilation since Nelio'=
s
commit [1]

Not sure I'm doing right but I'm compiling it for T=3Di686-native-linuxapp-=
gcc and
still having a few more errors even except for my code. And even if I fix a=
ll of
the errors, linkage fails as explained in the commit message of [1].

Are you sure you encountered this 32b compilation issue for the first time?


[1] http://dpdk.org/browse/dpdk/commit/?id=3Debbb81eb27daca0a89ee8f228fcf14=
1d9eb6ef1c


Thanks,
Yongseok