From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: [PATCH 2/6] net/tap: use correct channel for error
 logs
Date: Tue, 31 Jan 2017 17:04:48 +0000
Message-ID: <2F48A572-8DBA-49EC-8573-DD83FAB49D49@intel.com>
References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com>
 <1485855778-15496-2-git-send-email-pascal.mazon@6wind.com>
 <e1545ede-ee4c-57a4-e47e-67b23a7a7677@intel.com>
 <20170131085830.341b494d@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Pascal Mazon
 <pascal.mazon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 613A7B6D
 for <dev@dpdk.org>; Tue, 31 Jan 2017 18:04:50 +0100 (CET)
In-Reply-To: <20170131085830.341b494d@xeon-e3>
Content-Language: en-US
Content-ID: <173A07002348294DB1F0A76A8A4F7356@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On Jan 31, 2017, at 10:58 AM, Stephen Hemminger <stephen@networkplumber.o=
rg> wrote:
>=20
> On Tue, 31 Jan 2017 13:07:37 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>=20
>> On 1/31/2017 9:42 AM, Pascal Mazon wrote:
>>> Signed-off-by: Pascal Mazon <pascal.mazon@6wind.com>
>>> --- =20
>>=20
>> looks good to me.
>>=20
>=20
> Agreed, almost all uses of INFO as log level are wrong!
> Either the message is reporting a problem should be NOTICE, WARN, ERR
> or the message is often just developer checking the code and should be DE=
BUG.

I had already updated most of the logs even before Pascal sent he patch.

Regards,
Keith