From: Thomas Monjalon <thomas@monjalon.net>
To: Denis Sergeev <denserg.edu@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, anatoly.burakov@intel.com,
sivaprasad.tummala@amd.com, sdl.dpdk@linuxtesting.org
Subject: Re: [PATCH] power: fix off-by-one in uncore env bounds check
Date: Thu, 11 Jun 2026 00:36:27 +0200 [thread overview]
Message-ID: <2LSIGtK3S4OJmAd08vzpEQ@monjalon.net> (raw)
In-Reply-To: <20260603042205.116191-1-denserg.edu@gmail.com>
03/06/2026 06:21, Denis Sergeev:
> The condition in rte_power_set_uncore_env() uses '<=' instead of '<'
> when comparing the env argument against the size of uncore_env_str[].
> Since RTE_DIM(uncore_env_str) equals 4 and valid indices are 0..3,
> a caller passing env=4 bypasses the guard and causes an out-of-bounds
> read of uncore_env_str[4] at two sites within the same block.
>
> Fix by replacing '<=' with '<', consistent with the correct pattern
> already used in rte_power_uncore_init() in the same file.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: ac1edcb6621a ("power: refactor uncore power management API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Denis Sergeev <denserg.edu@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2026-06-10 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 4:21 [PATCH] power: fix off-by-one in uncore env bounds check Denis Sergeev
2026-06-10 22:36 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-16 11:11 Denis Sergeev
2026-04-24 16:58 ` Denis Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2LSIGtK3S4OJmAd08vzpEQ@monjalon.net \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=denserg.edu@gmail.com \
--cc=dev@dpdk.org \
--cc=sdl.dpdk@linuxtesting.org \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox